Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css bug to account for 4.5.1 bootstrap update #693

Merged
merged 1 commit into from Sep 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed bug related to unbinding a video element
- Fix tone does not stop when calling MeetingReadinessChecker.checkAudioOutput multiple times
- Fixed demo css format issue from updating to bootstrap 4.5.1

## [1.17.2] - 2020-09-08
### Added
Expand Down
4 changes: 2 additions & 2 deletions demos/browser/app/meeting/meeting.html
Expand Up @@ -213,7 +213,7 @@ <h1 class="h3 mb-3 font-weight-normal text-center">Select devices</h1>
<div id="flow-meeting" class="flow" style="position:absolute;left:15px;top:0;bottom:15px;right:15px">
<audio id="meeting-audio" style="display:none"></audio>
<div id="meeting-container" class="container-fluid h-100" style="display:flex; flex-flow:column">
<div class="row mb-3 mb-lg-0">
<div class="row mb-3 mb-lg-0" style="flex: unset;">
<div class="col-12 col-lg-3 text-center text-lg-left">
<div id="meeting-id" class="navbar-brand text-muted m-2"></div>
</div>
Expand Down Expand Up @@ -270,7 +270,7 @@ <h1 class="h3 mb-3 font-weight-normal text-center">Select devices</h1>
</button>
</div>
</div>
<div id="roster-tile-container" class="row flex-sm-grow-1 overflow-hidden h-100">
<div id="roster-tile-container" class="row flex-sm-grow-1 overflow-hidden h-100" style="flex: unset;">
<div id="roster-container" class="d-flex flex-column col-12 col-sm-6 col-md-5 col-lg-4 h-100">
<div class="bs-component" style="flex: 1 1 auto; overflow-y: scroll; height: 50%;">
<ul id="roster" class="list-group"></ul>
Expand Down
4 changes: 2 additions & 2 deletions demos/browser/app/meetingV2/meetingV2.html
Expand Up @@ -226,7 +226,7 @@ <h1 class="h3 mb-3 font-weight-normal text-center">Select devices</h1>
</div>
<audio id="meeting-audio" style="display:none"></audio>
<div id="meeting-container" class="container-fluid h-100" style="display:flex; flex-flow:column">
<div class="row mb-3 mb-lg-0">
<div class="row mb-3 mb-lg-0" style="flex-basis: auto;">
<div class="col-12 col-lg-3 order-1 order-lg-1 text-center text-lg-left">
<div id="meeting-id" class="navbar-brand text-muted m-0 m-lg-2"></div>
<div id="mobile-chime-meeting-id" class="text-muted d-block d-sm-none" style="font-size:0.65rem;"></div>
Expand Down Expand Up @@ -292,7 +292,7 @@ <h1 class="h3 mb-3 font-weight-normal text-center">Select devices</h1>
</button>
</div>
</div>
<div id="roster-tile-container" class="row flex-sm-grow-1 overflow-hidden h-100">
<div id="roster-tile-container" class="row flex-sm-grow-1 overflow-hidden h-100" style="flex: unset;">
<div id="roster-message-container" class="d-flex flex-column col-12 col-sm-6 col-md-5 col-lg-4 h-100">
<div class="bs-component" style="flex: 1 1 auto; overflow-y: scroll; height: 50%;">
<ul id="roster" class="list-group"></ul>
Expand Down
12 changes: 6 additions & 6 deletions demos/browser/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions demos/browser/package.json
Expand Up @@ -32,8 +32,8 @@
},
"dependencies": {
"amazon-chime-sdk-js": "file:../..",
"aws-sdk": "^2.751.0",
"bootstrap": "4.5.0",
"aws-sdk": "^2.755.0",
"bootstrap": "^4.5.1",
"compression": "^1.7.4",
"jquery": "^3.5.1",
"lodash": "^4.17.20",
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "amazon-chime-sdk-js",
"version": "1.17.10",
"version": "1.17.11",
"description": "Amazon Chime SDK for JavaScript",
"main": "build/index.js",
"types": "build/index.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion src/versioning/Versioning.ts
Expand Up @@ -18,7 +18,7 @@ export default class Versioning {
* Return string representation of SDK version
*/
static get sdkVersion(): string {
return '1.17.10';
return '1.17.11';
}

/**
Expand Down