Fix css bug to account for 4.5.1 bootstrap update #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simmkyu
reviewed
Sep 17, 2020
simmkyu
previously approved these changes
Sep 17, 2020
michhyun1
force-pushed
the
bootstrap-bug
branch
from
c053aae
to
aaf8d4d
Compare
simmkyu
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
Bootstrap introduced a code change in 4.5.1. (twbs/bootstrap#30940) that breaks the css format in our demo app. We just need to override the flex property to make sure the flex-basis property isnt 100%.
Also, bump bootstrap to 4.5.1.
Testing
Visual testing in the demo app.
npm run build:releaselocally? yesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.