fix(angular): Support strict: true
#890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8964373 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wlee221
commented
Dec 1, 2021
ErikCH
reviewed
Dec 1, 2021
Comment on lines
+31
to
+32
| loginMechanisms: Required<AuthContext>['config']['loginMechanisms']; | ||
| socialProviders: Required<AuthContext>['config']['socialProviders']; |
There was a problem hiding this comment.
Is adding Required going to cause any of the frameworks to complain if these props aren't passed into the authenticator?
There was a problem hiding this comment.
I don't think so, because the parent machine have default values for loginMechanisms and socialProviders even if these props weren't passed by the end user:
amplify-ui/packages/ui/src/machines/authenticator/index.ts
Lines 164 to 172 in 8964373
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #889
Description of changes: This sets
strictto true onexamples/angular, as it is defaults totrueon Angular 12+. Also refreshesyarn.lockto get aws-amplify/amplify-js#8984 patch.Resolves the following errors:
'aws-exports.js' implicitly has an 'any' typeElement implicitly has an 'any' type because index expression is not of type 'number'.Property 'socialProviders' does not exist on type '{ loginMechanisms?: ("username" | "email" | "phone_number")[] | undefined; signUpAttributes?: SignUpAttribute[] | undefined; socialProviders?: SocialProvider[] | undefined; } | undefined'.Could not find a declaration file for module 'graphql/error/GraphQLError'By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.