Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #904

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Version Packages #904

merged 1 commit into from
Dec 8, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 29, 2021

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@aws-amplify/ui-angular@2.0.4

Patch Changes

@aws-amplify/ui-react@2.1.3

Patch Changes

@aws-amplify/ui@3.0.4

Patch Changes

@aws-amplify/ui-vue@2.0.4

Patch Changes

@github-actions github-actions bot force-pushed the changeset-release/main branch 12 times, most recently from b54f6cc to 0838d8b Compare December 2, 2021 20:44
@wlee221 wlee221 added the run-tests Adding this label will trigger tests to run label Dec 2, 2021
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Dec 2, 2021
@wlee221 wlee221 temporarily deployed to ci December 2, 2021 23:02 Inactive
@wlee221 wlee221 temporarily deployed to ci December 2, 2021 23:02 Inactive
@wlee221 wlee221 temporarily deployed to ci December 2, 2021 23:02 Inactive
@wlee221 wlee221 temporarily deployed to ci December 2, 2021 23:26 Inactive
@kontralto-rob
Copy link

kontralto-rob commented Dec 3, 2021

@wlee221 Politely wondering if there's an estimated time frame for when this will be published and if there's anything I could do to help with review.

@wlee221
Copy link
Contributor

wlee221 commented Dec 6, 2021

Hi @kontralto-rob! We usually publish on Tuesdays and Thursdays, but we can do one earlier if any of these commits can unblock you. Which commits do you need, and can yarn install @aws-amplify/ui-[framework]@next unblock you?

@kontralto-rob
Copy link

kontralto-rob commented Dec 6, 2021

EDIT: The Angular Authenticator docs should include information about the needed polyfill:
(window as any).global = window

Thanks for the quick response @wlee221.

Unfortunately @next doesn't unblock me. I thought my problem was related to the support for strict: true but this does not seem to be the case. It did however change my error! So I appreciate the suggestion.

I am using the Angular version of the Authenticator, and it seems to be related to amazon-cognito-identity-js/node_modules/buffer/index.js's check for TYPED_ARRAY_SUPPORT. I think I'll have to submit a new issue for you folks. Cheers.

@wlee221
Copy link
Contributor

wlee221 commented Dec 6, 2021

@kontralto-rob Thanks for the additional context. Just to confirm, did adding (window as any).global = window resolve the build?

@wlee221
Copy link
Contributor

wlee221 commented Dec 6, 2021

In terms of mentioning that in the doc, it is on https://ui.docs.amplify.aws/getting-started/installation?platform=angular#troubleshooting but I know it's very hard to find, and rather should be cross-linked from Authenticator doc itself.

I have an open issue for that -- #892. I'll work on getting it resolved by next week.

@kontralto-rob
Copy link

@wlee221 (window as any).global = window did resolve the build.

Thanks for working to get that in the doc, I'm sure it'll help others avoid tripping over this like I did.

Cheers

@github-actions github-actions bot force-pushed the changeset-release/main branch 3 times, most recently from c917ca3 to b214701 Compare December 8, 2021 15:51
@wlee221 wlee221 added the run-tests Adding this label will trigger tests to run label Dec 8, 2021
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Dec 8, 2021
@wlee221 wlee221 temporarily deployed to ci December 8, 2021 20:52 Inactive
@wlee221 wlee221 temporarily deployed to ci December 8, 2021 20:52 Inactive
@wlee221 wlee221 temporarily deployed to ci December 8, 2021 20:52 Inactive
@wlee221 wlee221 added the run-tests Adding this label will trigger tests to run label Dec 8, 2021
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Dec 8, 2021
@wlee221 wlee221 temporarily deployed to ci December 8, 2021 21:24 Inactive
@wlee221 wlee221 temporarily deployed to ci December 8, 2021 21:24 Inactive
@wlee221 wlee221 temporarily deployed to ci December 8, 2021 21:24 Inactive
@wlee221 wlee221 temporarily deployed to ci December 8, 2021 21:47 Inactive
@wlee221 wlee221 enabled auto-merge (squash) December 8, 2021 21:48
@wlee221 wlee221 merged commit 70add7b into main Dec 8, 2021
@wlee221 wlee221 deleted the changeset-release/main branch December 8, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants