Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: README nit missed in last review #10670

Merged
merged 1 commit into from Nov 15, 2022
Merged

Conversation

stocaaro
Copy link
Contributor

Description of changes

Missed nit from prior review

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stocaaro stocaaro requested a review from a team as a code owner November 15, 2022 01:15
Copy link
Contributor

@cshfang cshfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@codecov-commenter
Copy link

Codecov Report

Merging #10670 (62e3fbe) into main (4075667) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #10670   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files         196      196           
  Lines       18240    18240           
  Branches     3888     3888           
=======================================
  Hits        15613    15613           
  Misses       2549     2549           
  Partials       78       78           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abdallahshaban557 abdallahshaban557 merged commit 8a66823 into main Nov 15, 2022
@stocaaro stocaaro deleted the stocaaro-patch-3 branch November 22, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants