fix: README grammer/wording #10667
Merged
fix: README grammer/wording #10667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
reviewed
Nov 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #10667 +/- ##
=======================================
Coverage 85.59% 85.59%
=======================================
Files 196 196
Lines 18240 18240
Branches 3888 3888
=======================================
Hits 15613 15613
Misses 2549 2549
Partials 78 78 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cshfang
reviewed
Nov 14, 2022
cshfang
reviewed
Nov 14, 2022
Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
Co-authored-by: Chris F <5827964+cshfang@users.noreply.github.com>
jimblanc
approved these changes
Nov 14, 2022
| ``` | ||
|
|
||
| - The `JS` export has been removed from `@aws-amplify/core` in favor the exporting the functions it contained. | ||
| - Any calls to `Amplify.Auth`, `Amplify.Cache`, and `Amplify.ServiceWorker` are no longer supported, instead your code should use the named exports. For example: | ||
| - Any calls to `Amplify.Auth`, `Amplify.Cache`, and `Amplify.ServiceWorker` are no longer supported. Instead , your code should use the named exports. For example: |
There was a problem hiding this comment.
Nit: Extra space before comma Instead , I'll blame Chris for this one 😛
cshfang
approved these changes
Nov 14, 2022
| ``` | ||
|
|
||
| - The `JS` export has been removed from `@aws-amplify/core` in favor the exporting the functions it contained. | ||
| - Any calls to `Amplify.Auth`, `Amplify.Cache`, and `Amplify.ServiceWorker` are no longer supported, instead use the named exports. For example: | ||
| - Any calls to `Amplify.Auth`, `Amplify.Cache`, and `Amplify.ServiceWorker` are no longer supported. Instead , your code should use the named exports. For example: |
There was a problem hiding this comment.
Remove extra space
Suggested change
| - Any calls to `Amplify.Auth`, `Amplify.Cache`, and `Amplify.ServiceWorker` are no longer supported. Instead , your code should use the named exports. For example: | |
| - Any calls to `Amplify.Auth`, `Amplify.Cache`, and `Amplify.ServiceWorker` are no longer supported. Instead, your code should use the named exports. For example: |
There was a problem hiding this comment.
Well garbage. I scrolled past this and hit submit before seeing it :-/ Guess I get to pad my commit stats a little bit more... #10670
This was referenced Aug 16, 2023
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Re-reading the README update and making updates to language that reads awkwardly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.