Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify datastore construction #317

Merged
merged 3 commits into from Dec 8, 2021
Merged

Simplify datastore construction #317

merged 3 commits into from Dec 8, 2021

Commits on Dec 6, 2021

  1. model datastore cli options

    @ecordell
    ecordell committed Dec 6, 2021
    Copy the full SHA
    3dbe72f View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. support both config object (for cobra bindings) and functional options 

    for datastore
    @ecordell
    ecordell committed Dec 7, 2021
    Copy the full SHA
    782a9d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. add a cap to iterations for newenemy test 

    occasionally the number of iterations picked will take longer than the
timeout for the test suite. capping it means that we sometimes will not
run the full iterations to be convincing, but the effect should be
amortized over PR runs. The cap (and timeout) can be removed for any
change that we suspect may have implications for the test.
    @ecordell
    ecordell committed Dec 8, 2021
    Copy the full SHA
    72e7745 View commit details
    Browse the repository at this point in the history