Simplify datastore construction #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
ds-builder
branch
4 times, most recently
from
30ec2dd
to
a92942b
Compare
ecordell
changed the title
ecordell
force-pushed
the
ds-builder
branch
2 times, most recently
from
1def5da
to
1783cec
Compare
github-actions
bot
added
the
area/tooling
ecordell
force-pushed
the
ds-builder
branch
2 times, most recently
from
7ab53fe
to
3bbcb1c
Compare
github-actions
bot
added
area/dependencies
jzelinskie
requested changes
Dec 7, 2021
pkg/cmd/serve/datastore_options.go
Outdated
| @@ -0,0 +1,135 @@ | |||
| // Code generated by github.com/ecordell/optgen. DO NOT EDIT. | |||
There was a problem hiding this comment.
Can we name this file with a regex that we can add to .gitattributes?
pkg/cmd/serve/datastore.go
Outdated
| @@ -0,0 +1,156 @@ | |||
| package serve | |||
There was a problem hiding this comment.
There will be places other than serve that needs the datastore to be initialized. This might be best in pkg/cmd top-level
jzelinskie
previously approved these changes
Dec 7, 2021
github-actions
bot
added
the
area/tooling
occasionally the number of iterations picked will take longer than the timeout for the test suite. capping it means that we sometimes will not run the full iterations to be convincing, but the effect should be amortized over PR runs. The cap (and timeout) can be removed for any change that we suspect may have implications for the test.
jzelinskie
approved these changes
Dec 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler to build datastores from CLI args