Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetVerificationKey typing to include undefined #329

Merged
merged 2 commits into from Oct 10, 2022
Merged

Fix GetVerificationKey typing to include undefined #329

merged 2 commits into from Oct 10, 2022

Conversation

AaronMoat
Copy link
Contributor

@AaronMoat AaronMoat commented Oct 10, 2022 •
edited

Description

Update GetVerificationKey type to reflect reality

References

Resolves #328

Testing

None so far - does this deserve a test? tests/ts-definitions.tests.ts is pretty lightweight so far.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs I don't think this is required.
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@AaronMoat AaronMoat requested a review from a team as a code owner October 10, 2022 06:44
adamjmcgrath
adamjmcgrath approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AaronMoat

@adamjmcgrath adamjmcgrath merged commit 9574b04 into auth0:master Oct 10, 2022
@adamjmcgrath adamjmcgrath mentioned this pull request Oct 10, 2022
Merged
@AaronMoat AaronMoat deleted the fix-express-jwt-secret-typing branch October 10, 2022 12:30
This was referenced Oct 13, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expressJwtSecret can return undefined which is not reflected in GetVerificationKey type
2 participants
@AaronMoat @adamjmcgrath