Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GetVerificationKey type to match node-jwks-rsa #305

Merged
merged 1 commit into from Dec 22, 2022

Conversation

kylerm42
Copy link
Contributor

@kylerm42 kylerm42 commented Oct 13, 2022

Description

A PR was recently merged to auth0/node-jwks-rsa that changed the type of GetVerificationKey, which breaks the interaction with express-jwt. This PR updates the type here to match the change there.

References

Testing

None, does this need a test?

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@manast
Copy link

manast commented Nov 9, 2022

Whats holding this PR to be merged?

@jfromaniello jfromaniello merged commit bcad8af into auth0:master Dec 22, 2022
@jfromaniello
Copy link
Member

Thank you, published in v8.1.0.

Note v8 is a major because of a major upgrade in jsonwebtoken, but it should not affect applications on most cases.

@jfromaniello
Copy link
Member

And sorry about the delay 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetVerificationKey type doesn't match auth0/node-jwks-rsa
3 participants