New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UART v2 #443
Merged
Merged
UART v2 #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeaurivage
force-pushed
the
uart-v2
branch
2 times, most recently
from
May 21, 2021 17:50
74142a8
to
158a10b
Compare
jbeaurivage
force-pushed
the
uart-v2
branch
2 times, most recently
from
June 9, 2021 15:31
26f08b3
to
43f3be9
Compare
ianrrees
reviewed
Jun 11, 2021
jbeaurivage
force-pushed
the
uart-v2
branch
2 times, most recently
from
June 15, 2021 22:51
d903cf4
to
a7ead1e
Compare
Some comments:
|
By the way, I think the type-level stuff meshed really well here. You were able to use the |
jbeaurivage
force-pushed
the
uart-v2
branch
2 times, most recently
from
June 16, 2021 20:11
f562eeb
to
9b7dc71
Compare
jbeaurivage
commented
Jun 16, 2021
ianrrees
reviewed
Jun 18, 2021
@jbeaurivage, since you still have boxes unchecked, I converted this to a draft PR. I hope that's ok. It helps me identify merge candidates when browsing the PR list. |
@bradleyharden no problem. Hopefully it should be ready soon! |
Bugfix: enable USART internal clock mode on init.
* Added DMA support * Uart tx and rx fields are now public instead of split()/join() methods.
Improve CharSize API Registers methods take Flags and Status structs instead of raw bits Remove From implementations for StopBits, BitOrder, Baud, etc.
RXEN/TXEN will only be enabled if the underlying Pads have RX/TX capability.
Move BITS constant from CharSize to FixedCharSize trait and rename to SIZE
kaizensparc
pushed a commit
to kaizensparc/atsamd
that referenced
this pull request
Dec 24, 2021
Provide a new UART driver with an API similar to `sercom::v2::spi` Co-authored-by: Ian Rees <code@ianrees.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a new UART driver with an API similar to
sercom::v2::spi
.In fact, most of the type-level code was shamelessly copied from @bradleyharden's SPI driver. Thanks for doing most of the legwork!
Supported
Not supported
Future
-mode - Use DMA transfers insteadTo Do
Dependencies
This PR is dependent on the new
Pads
API (#434).Related issues
Closes #329