Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PropType.elementType where possible #600

Merged
merged 2 commits into from May 21, 2019
Merged

Use PropType.elementType where possible #600

merged 2 commits into from May 21, 2019

Conversation

nnashwin
Copy link
Contributor

@nnashwin nnashwin commented May 11, 2019 •
edited by sindresorhus

…e the elementType PropType instead of PropTypes.func
@sindresorhus
@lukechilds

Fixes #598

@nnashwin nnashwin mentioned this pull request May 11, 2019
Closed
@sindresorhus sindresorhus changed the title changes the PropTypes for components that are being passed down to us… Use PropType.elementType where possible May 21, 2019
@sindresorhus sindresorhus merged commit 3cb5aa7 into atomiclabs:master May 21, 2019
@sindresorhus
Copy link
Contributor

This looks good. Thank you for contributing, @ru-lai 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the new elementType PropType
2 participants
@nnashwin @sindresorhus