Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new elementType PropType #598

Closed
sindresorhus opened this issue Apr 17, 2019 · 3 comments · Fixed by #600
Closed

Use the new elementType PropType #598

sindresorhus opened this issue Apr 17, 2019 · 3 comments · Fixed by #600
Labels
enhancement good first issue help wanted

Comments

@sindresorhus
Copy link
Contributor

See facebook/prop-types#211

We should use it instead of PropType.func in most places, except for change handlers.
@nnashwin
Copy link
Contributor

nnashwin commented May 8, 2019

@sindresorhus I'd like to work on this issue.
I'll get started and make a pr when ready.

@sindresorhus
Copy link
Contributor Author

@ru-lai Awesome 👍

@nnashwin
Copy link
Contributor

PR #600 should solve this issue.

@nnashwin nnashwin mentioned this issue May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use PropType.elementType where possible
2 participants
@sindresorhus @nnashwin