Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

clean up outstanding V8 warnings about deprecated APIs #186

Merged
merged 1 commit into from May 27, 2019

Conversation

shiftkey
Copy link
Contributor

@shiftkey shiftkey commented May 24, 2019

  • no V8 build warnings on Windows
  • no V8 build warnings on macOS
  • no V8 build warnings on Linux

@shiftkey
Copy link
Contributor Author

The last remaining V8 warning on Windows is not relevant to keytar's usage, and will hopefully go away with a future tooling update:

c:\users\appveyor\.node-gyp\5.0.0\include\node\v8.h(4458): warning C4996: 'v8::WasmModuleObject::SerializedModule': was declared deprecated (compiling source file ..\src\async.cc) [C:\projects\node-keytar\build\keytar.vcxproj]
  c:\users\appveyor\.node-gyp\5.0.0\include\node\v8.h(4380): note: see declaration of 'v8::WasmModuleObject::SerializedModule' (compiling source file ..\src\async.cc)
c:\users\appveyor\.node-gyp\5.0.0\include\node\v8.h(10172): warning C4996: 'v8::Value::ToBoolean': was declared deprecated (compiling source file ..\src\async.cc) [C:\projects\node-keytar\build\keytar.vcxproj]
  c:\users\appveyor\.node-gyp\5.0.0\include\node\v8.h(2387): note: see declaration of 'v8::Value::ToBoolean' (compiling source file ..\src\async.cc)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant