Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address deprecation warnings reported by Node 12+ #143

Closed
shiftkey opened this issue May 27, 2019 · 0 comments · Fixed by #144
Closed

address deprecation warnings reported by Node 12+ #143

shiftkey opened this issue May 27, 2019 · 0 comments · Fixed by #144
Labels
good first issue help wanted

Comments

@shiftkey
Copy link
Member

Node 12 has marked some of these APIs as deprecated:

c:\projects\lean-mean-registry-client\src\main.cc(64): warning C4996: 'v8::Object::Set': was declared deprecated [C:\projects\lean-mean-registry-client\build\registry.vcxproj]
  c:\users\appveyor\.node-gyp\12.3.1\include\node\v8.h(3358): note: see declaration of 'v8::Object::Set'
c:\projects\lean-mean-registry-client\src\main.cc(65): warning C4996: 'v8::Object::Set': was declared deprecated [C:\projects\lean-mean-registry-client\build\registry.vcxproj]
  c:\users\appveyor\.node-gyp\12.3.1\include\node\v8.h(3358): note: see declaration of 'v8::Object::Set'
c:\projects\lean-mean-registry-client\src\main.cc(66): warning C4996: 'v8::Object::Set': was declared deprecated [C:\projects\lean-mean-registry-client\build\registry.vcxproj]
  c:\users\appveyor\.node-gyp\12.3.1\include\node\v8.h(3358): note: see declaration of 'v8::Object::Set'
c:\projects\lean-mean-registry-client\src\main.cc(76): warning C4996: 'v8::Object::Set': was declared deprecated [C:\projects\lean-mean-registry-client\build\registry.vcxproj]
  c:\users\appveyor\.node-gyp\12.3.1\include\node\v8.h(3358): note: see declaration of 'v8::Object::Set'
c:\projects\lean-mean-registry-client\src\main.cc(77): warning C4996: 'v8::Object::Set': was declared deprecated [C:\projects\lean-mean-registry-client\build\registry.vcxproj]
  c:\users\appveyor\.node-gyp\12.3.1\include\node\v8.h(3358): note: see declaration of 'v8::Object::Set'
c:\projects\lean-mean-registry-client\src\main.cc(78): warning C4996: 'v8::Object::Set': was declared deprecated [C:\projects\lean-mean-registry-client\build\registry.vcxproj]
  c:\users\appveyor\.node-gyp\12.3.1\include\node\v8.h(3358): note: see declaration of 'v8::Object::Set'

See atom/node-keytar#186 for a suggested way to migrate to the recommended API, using Nan::GetCurrentContext()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: v8 deprecations warnings and make module context aware
1 participant
@shiftkey