Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

clean up outstanding V8 warnings about deprecated APIs #186

Merged
merged 1 commit into from May 27, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/async.cc
Expand Up @@ -190,8 +190,20 @@ void FindCredentialsWorker::HandleOKCallback() {
cred.second.data(),
cred.second.length()).ToLocalChecked();

obj->Set(Nan::New("account").ToLocalChecked(), account);
obj->Set(Nan::New("password").ToLocalChecked(), password);
#ifndef _WIN32
#pragma GCC diagnostic ignored "-Wunused-result"
#endif
obj->Set(
Nan::GetCurrentContext(),
Nan::New("account").ToLocalChecked(),
account);
#ifndef _WIN32
#pragma GCC diagnostic ignored "-Wunused-result"
#endif
obj->Set(
Nan::GetCurrentContext(),
Nan::New("password").ToLocalChecked(),
password);

Nan::Set(val, idx, obj);
++idx;
Expand Down