Go 1.18 released

[atc0005]

Overview

Need to refresh oldstable to use Go 1.17 and stable to use the new Go 1.18 version.

References to Go 1.16 can be removed entirely.

The Go 1.18rc1-based unstable container can be updated to 1.18 for the time being until the first 1.19-based pre-release becomes available.

NOTE: golangci-lint is still not 1.18 "certified", so will need to build from source for the time being. This requires updating the stable variants to match the current unstable container, while keeping the oldstable container logic (e.g., install via official installation script) intact.

TODO

• update oldstable image to use Go 1.17
• update stable image to use Go 1.18
  • update stable image to use same steps as unstable image for building/installing current golangci-lint
    • building from source is needed until golangci-lint officially supports Go 1.18 (and running within a Go 1.18 container)
    • not needed for oldstable image (now based on Go 1.17)
• update unstable image to use Go 1.18
  • docker: bump golang from 1.18rc1 to 1.18.0 in /unstable #556
• remove any references to Go 1.16

References

• https://golang.org/doc/go1.18
• https://groups.google.com/g/golang-announce/c/6gJm7mgF6rw/m/5w-bU37mAQAJ
• Support of generics golangci/golangci-lint#2649

[atc0005]

Note to self:

Probably worth making changes in small steps.

Update unstable image to official Go 1.18 release, but keep the stable image on 1.17 for the time being for best compatibility with golangci-lint.

Not sure yet about the oldstable image.

[atc0005]

Update unstable image to official Go 1.18 release

Using golangci-lint with Go 1.18 requires a new setting. Some linters are disabled when enabling Go 1.18 support.

See:

• Support of generics golangci/golangci-lint#2649 (comment)

Example (borrowed from goreleaser/goreleaser#2989):

diff --git a/.golangci.yaml b/.golangci.yaml
index 126b222f13..a0731d5063 100644
--- a/.golangci.yaml
+++ b/.golangci.yaml
@@ -1,3 +1,5 @@
+run:
+  go: 1.18
 linters:
   enable:
     - thelper

[atc0005]

Note: The golangci-lint v1.45.0 Docker images were updated to use Go 1.18 as the base:

• docker: bump golangci/golangci-lint from v1.44.2-alpine to v1.45.0-alpine in /stable/linting #564
• Update golangci-lint from v1.44.2 to v1.45.0 #565

Since we're postponing upgrading "stable" images for this project to Go 1.18, I may need to update the stable-lint-only image to explicitly use Go 1.17 as the base.

[atc0005]

Go 1.19beta1 has been released. Cross-post from #656 (comment):

It's time to update the images accordingly:

• Go 1.16 dropped, 1.17 becomes the oldstable version
• Go 1.18 is used for stable variants
• Go 1.19 is used for unstable

We'll need to drop any hard-coded Go 1.17 specific settings in golangci-lint and allow auto-detection to take place.

[atc0005]

Considering the core work complete. The process of updating the disable linters list to drop linters which have gained Go 1.18 compatibility will be an ongoing process.