Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go unstable=1.19, stable=1.18, oldstable=1.17 #659

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Jun 19, 2022

CHANGES

  • each image type (stable, unstable, oldstable) has their own
    copy of the golangci-lint config file with the stable variants
    being given a copy of the via the Makefile build recipe
  • each image type (stable, unstable, oldstable) is given a copy
    of the markdownlint config file via Makefile build recipe
  • Makefile clean recipe updated to remove temporary copies of linter
    config files
  • Makefile build recipe updated to limit copying of linter config
    files to just the images which use them
  • oldstable image
    • explicitly specifies the Go version limit for golangci-lint as Go
      1.17
    • updated Go from 1.16.15 to 1.17.11
  • unstable image
    • explicitly specifies the Go version limit for golangci-lint as Go
      1.18 (for now)
    • updated Go from 1.18.3 to 1.19beta1
  • stable image
    • variants providing the golangci-lint linter explicitly specify the
      Go version limit for golangci-lint as Go 1.18
    • updated Go from 1.17.11 to 1.18.3
  • update README to drop compatibility notes regarding the oldstable
    image and older staticcheck version used for Go 1.16 compatibility
  • update go.mod file to reflect current stable version of Go (1.18)
    with a note to update the version going forward

refs GH-557
refs GH-656

CHANGES

- each image type (`stable`, `unstable`, `oldstable`) has their own
  copy of the golangci-lint config file with the `stable` variants
  being given a copy of the via the Makefile build recipe
- each image type (`stable`, `unstable`, `oldstable`) is given a copy
  of the markdownlint config file via Makefile build recipe
- Makefile clean recipe updated to remove temporary copies of linter
	config files
- Makefile build recipe updated to limit copying of linter config
  files to just the images which use them
- `oldstable` image
  - explicitly specifies the Go version limit for golangci-lint as Go
    1.17
  - updated Go from `1.16.15` to `1.17.11`
- `unstable` image
  - explicitly specifies the Go version limit for golangci-lint as Go
    1.18 (for now)
  - updated Go from `1.18.3` to `1.19beta1`
- `stable` image
  - variants providing the golangci-lint linter explicitly specify the
    Go version limit for golangci-lint as Go 1.18
  - updated Go from `1.17.11` to `1.18.3`
- update README to drop compatibility notes regarding the `oldstable`
  image and older `staticcheck` version used for Go 1.16 compatibility
- update go.mod file to reflect current stable version of Go (1.18)
  with a note to update the version going forward

refs GH-557
refs GH-656
@atc0005 atc0005 added this to the Next Release milestone Jun 19, 2022
@atc0005 atc0005 self-assigned this Jun 19, 2022
@atc0005 atc0005 merged commit 1b07355 into master Jun 19, 2022
@atc0005 atc0005 deleted the i557-i656-update-go-versions-used-in-all-images branch June 19, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant