Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh list of disabled linters due to Go 1.18+ incompatibilities #658

Closed
atc0005 opened this issue Jun 19, 2022 · 0 comments · Fixed by #660
Closed

Refresh list of disabled linters due to Go 1.18+ incompatibilities #658

atc0005 opened this issue Jun 19, 2022 · 0 comments · Fixed by #660
Assignees
@atc0005
Labels
stable unstable
Milestone
v0.6.14

Comments

@atc0005
Copy link
Owner

atc0005 commented Jun 19, 2022 •
edited

The list of compatible/incompatible linters on golangci/golangci-lint#2649 should be reviewed and any linters recently fixed/updated to work with Go 1.18 should be:

  • removed from the explicit disable list
  • added back to the enabled list (if previously & explicitly enabled)

Refs:
@atc0005 atc0005 added this to the Next Release milestone Jun 19, 2022
@atc0005 atc0005 self-assigned this Jun 19, 2022
atc0005 added a commit that referenced this issue Jun 19, 2022
@atc0005
Update disabled linters for current 1.18 compat
549345c 
Remove from disabled list:

- `gosimple`
- `stylecheck`
- `unused`

Return to explicitly enabled list:

- `stylecheck`

refs GH-658
atc0005 added a commit that referenced this issue Jun 19, 2022
@atc0005
Update disabled linters for current 1.18 compat
cbf186f 
Remove from disabled list:

- `gosimple`
- `stylecheck`
- `unused`

Return to explicitly enabled list:

- `stylecheck`

refs GH-658
@atc0005 atc0005 mentioned this issue Jun 19, 2022
Merged
atc0005 added a commit that referenced this issue Jun 20, 2022
@atc0005
Revert stable image linters to original list
b7ea4d4 
As part of promoting the versions of Go used in each image
type the linters enabled for the unstable image were ported
as-is to the stable container.

This commit reverts the unintended changes restoring the
original list of linters used by the unstable image.

Specifically:

- errcheck
- gochecknoglobals
- gocognit
- gocyclo
- goerr113

refs GH-557
refs GH-656
refs GH-658
@atc0005 atc0005 mentioned this issue Jun 20, 2022
Merged
This was referenced Jul 19, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atc0005 atc0005

Labels
stable unstable
Projects
None yet
Milestone
v0.6.14
Development

Successfully merging a pull request may close this issue.

Update disabled linters for current 1.18 compatibility atc0005/go-ci
1 participant
@atc0005