bump jinja2 to v3 #634
Merged
bump jinja2 to v3 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2 is unsupported and causes an error due to a transitive dependency issue
[no ci]
|
@ajstewart I think this is better than adding Markupsafe to our dependencies since we don't directly depend on Markupsafe, Jinja2 does. If you agree, I suggest merging this into dev then rebasing #627 onto dev, and removing the Markupsafe pin in #627. |
Yep makes sense, I'm happy with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja2 depends on Markupsafe but the constraint is a minimum version with no upper bound. Markupsafe recently removed a deprecated function which causes the following error:
The problem has been reported by a few Jinja2 users, e.g. pallets/jinja#1585. The Jinja2 dev team recommends upgrading Jinja2 - they refuse to patch the v2 releases with an upper bound to their Markupsafe constraint as it's considered "unsupported".
This PR bumps out Jinja2 requirement to
Jinja2 = "^3.0.3". We only use Jinja2 for templating the run config files - I see no breaking changes and the tests passed locally.