skip empty groups in new sources groupby-apply #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marxide
force-pushed
the
iss-631-groupby-apply-indexerror
branch
from
7b7b8f4
to
cfb7fab
Compare
marxide
added
bug
ajstewart
reviewed
Feb 23, 2022
| @@ -79,6 +79,9 @@ def get_image_rms_measurements( | |||
| The group dataframe with the 'img_diff_true_rms' column added. The | |||
| column will contain 'NaN' entires for sources that fail. | |||
| """ | |||
| if len(group) == 0: | |||
There was a problem hiding this comment.
Does group have a .empty flag like the dataframes?
There was a problem hiding this comment.
Yes, they appear to be Pandas DataFrames within that function. As far as I can tell, len(df) == 0 and df.empty are equivalent in this case.
ajstewart
approved these changes
Feb 23, 2022
marxide
force-pushed
the
iss-631-groupby-apply-indexerror
branch
from
cfb7fab
to
ba02eb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #631