Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update vendored mspec in spec-runner #2189

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

lopopolo
Copy link
Member

@lopopolo lopopolo commented Sep 24, 2022

Proposed tree: https://github.com/artichoke/mspec/tree/artichoke-vendor-proposed-gh-2189

Status

Blocked on Hash#compare_by_identity not being implemented.

$ bundle exec rake spec
cargo run -q -- enforced-specs.toml
Traceback (most recent call last):
        8: from /artichoke/virtual_root/src/lib/spec_runner.rb:48
        7: from /artichoke/virtual_root/src/lib/spec_runner.rb:48:in require
        6: from /artichoke/virtual_root/src/lib/mspec.rb:2
        5: from /artichoke/virtual_root/src/lib/mspec.rb:2:in require
        4: from /artichoke/virtual_root/src/lib/mspec/matchers.rb:31
        3: from /artichoke/virtual_root/src/lib/mspec/matchers.rb:31:in require
        2: from /artichoke/virtual_root/src/lib/mspec/matchers/raise_error.rb:1
/artichoke/virtual_root/src/lib/mspec/matchers/raise_error.rb:2: undefined method 'compare_by_identity' (NoMethodError)
NoMethodError (undefined method 'compare_by_identity')
rake aborted!
Command failed with status (1): [cargo run -q -- enforced-specs.toml...]
/Users/lopopolo/dev/artichoke/artichoke/Rakefile:132:in `block (2 levels) in <top (required)>'
/Users/lopopolo/dev/artichoke/artichoke/Rakefile:131:in `chdir'
/Users/lopopolo/dev/artichoke/artichoke/Rakefile:131:in `block in <top (required)>'
/usr/local/var/rbenv/versions/3.1.2/bin/bundle:25:in `load'
/usr/local/var/rbenv/versions/3.1.2/bin/bundle:25:in `<main>'
Tasks: TOP => spec
(See full trace by running task with --trace)

@lopopolo lopopolo added A-deps Area: Source and library dependencies. A-spec Area: ruby/spec infrastructure and completeness. S-wip Status: This pull request is a work in progress. labels Sep 24, 2022
@lopopolo
Copy link
Member Author

@lopopolo
Copy link
Member Author

This PR is blocking #2263.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: Source and library dependencies. A-spec Area: ruby/spec infrastructure and completeness. S-wip Status: This pull request is a work in progress.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant