Tests in spec-runner/vendor/ruby are not for MRI 3.1.2

[xulaus]

Tests in spec-runner/vendor appear to not be for MRI 3.1.2 despite that being the target API listed in the documentation (RUBYSPEC.md).

For example, there is test in the spec for String#upcase that relies on String#taint which was removed in Ruby 2.7 (tracking issue here)

artichoke/spec-runner/vendor/spec/core/string/upcase_spec.rb

Lines 68 to 72 in 3835003

	it "taints result when self is tainted" do
	"".taint.upcase.tainted?.should == true
	"X".taint.upcase.tainted?.should == true
	"x".taint.upcase.tainted?.should == true
	end

The vendored version in artichoke-core is up to date however

artichoke/artichoke-backend/vendor/ruby/spec/ruby/core/string/upcase_spec.rb

Lines 68 to 74 in 3835003

	ruby_version_is ''...'2.7' do
	it "taints result when self is tainted" do
	"".taint.upcase.should.tainted?
	"X".taint.upcase.should.tainted?
	"x".taint.upcase.should.tainted?
	end
	end

[xulaus]

I'd happly submit a PR for this, but I was unsure if there was some upgrade process for the vendored rubies that I couldn't see.

[lopopolo]

Hi @xulaus thanks for the report and so sorry it took me a while to get to this. I would very much like to do this but the upgrade process is fairly involved and I think I'm the only one who can do it.

The @artichoke organization maintains forks of both MSpec (the ruby/spec test framework) and ruby/spec:

• https://github.com/artichoke/mspec
• https://github.com/artichoke/spec

These forks maintain a branch called artichoke-vendor which as of now forks off from Ruby 2.6.3 and applies some patches to get things running on Artichoke.

A snapshot of these repositories from their artichoke-vendor branch is copied into the spec-runner workspace at spec-runner/vendor/{mspec,spec}.

The above info should be laid out here: https://github.com/artichoke/artichoke/blob/7d59abcfafbca574a6e10996e977697fdab39314/spec-runner/vendor/README.md.

To upgrade to Ruby 3.1.2's version of ruby/spec requires updating MSpec. A PR is up for this:

• [WIP] Update vendored mspec in spec-runner #2189

Unfortunately, #2189 is blocked on missing parts of the Hash API. I was planning on deferring this until re-implementing Hash in Rust, but the timelines on this work are unknown.