feat: ability to add additional configmaps #11445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of notfromstatefarm/argo-cd Co-authored-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> Signed-off-by: bilalcaliskan <bilalcaliskan@protonmail.com>
Co-authored-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> Signed-off-by: bilalcaliskan <bilalcaliskan@protonmail.com>
Co-authored-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> Signed-off-by: bilalcaliskan <bilalcaliskan@protonmail.com>
…settings rbac can' command Co-authored-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com> Signed-off-by: bilalcaliskan <bilalcaliskan@protonmail.com>
Signed-off-by: bilalcaliskan <bilalcaliskan@protonmail.com>
Codecov ReportBase: 47.43% // Head: 47.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #11445 +/- ##
==========================================
- Coverage 47.43% 47.39% -0.04%
==========================================
Files 246 246
Lines 41824 41902 +78
==========================================
+ Hits 19838 19861 +23
- Misses 19990 20043 +53
- Partials 1996 1998 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bilalcaliskan
changed the title
bilalcaliskan
changed the title
|
@crenshaw-dev @jannfis can you please take a look? As you know this PR is the re-implementation of PR #9976 for the issue #8324 . All reviews are welcomed. Cheers! |
Signed-off-by: bilalcaliskan <bilalcaliskan@protonmail.com>
|
@crenshaw-dev |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bilalcaliskan bilalcaliskan@protonmail.com
Co-authored-by: notfromstatefarm 86763948+notfromstatefarm@users.noreply.github.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
This is the continuation PR of #9976 since it is not blocked somehow.
This PR implements the feature of
additional RBAC configmapswhich is also stated in PR #9976.Any configmaps with the label
argocd.argoproj.io/cm-type=rbacwill be used and watched for changes. This will simplify of adding/managing RBAC rules on large enterprise environments.