Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for multiple rbac ConfigMaps (Alpha) #17828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

meln5674
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixes #8324

This work is based on these abandoned PRs:

In large multi-tenant instances, the size of the policy.csv may exceed the limit for a single Kubernetes resource.

This patch adds the label argocd.argoproj.io/cm-type=policy-csv, which, when placed on a configmap in the same namespace, causes it to be included in the casbin policy according to the same rules as the existing argocd-cm-rbac configmap, with outputs sorted alphabetically by configmap name before concatenation to ensure predictable outputs.

The admin CLI has been updated to also check for these additional configmaps and generate the final policy accordingly.

E2E tests have been added to ensure that these extra configmaps' policies are included when created, as well as correctly removed when they are changed or updated.

NOTE: I could have sworn I made this PR as a draft a few days ago, but it was gone when I went to update it. Please excuse me if I've accidentally made a duplicate

@meln5674 meln5674 requested review from a team as code owners April 13, 2024 19:31
@meln5674 meln5674 force-pushed the feature/multiple-cm-rbac branch 2 times, most recently from 5cc3359 to 4b35e53 Compare April 14, 2024 18:06
Signed-off-by: Andrew Melnick <meln5674@kettering.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for multiple rbac configmaps
1 participant