Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Redis with ValKey #17892

Closed
hairmare opened this issue Apr 18, 2024 · 5 comments · May be fixed by #17904
Closed

Replace Redis with ValKey #17892

hairmare opened this issue Apr 18, 2024 · 5 comments · May be fixed by #17904
Labels
enhancement New feature or request

Comments

@hairmare
Copy link
Contributor

hairmare commented Apr 18, 2024

Summary

Redis Inc announced that they are changing Redis' license to the source available BUSL license here which is in violation of CNCF policy and does not align with the Argo Projects values.

The BSD-3-Clause licensed Redis OSS code has now been forked as ValKey in an effort hosted by the Linux Foundation.

After ValKey's first generally available (GA) release and stable release it is time to start replacing Redis.

Prior to this issue, the change was discussed here: #17599

Motivation

Taking swift action when this kind of change happens in our supply chain is a the core of upholding our opensource values.

Proposal

I propose to write a Argo CD enhancement proposal in docs/proposals/valkey.md to further detail this architecture decision and to then implement it by replacing the manifests in manifests/base/redis along with proper documentation to communicate this change.

@hairmare hairmare added the enhancement New feature or request label Apr 18, 2024
@hairmare
Copy link
Contributor Author

hairmare commented Apr 18, 2024

I'd be happy to give writing an enhancement proposal a go, feel free to assign me and provide any pointers if there is anything i missed or should specifically be addressed for this case.

@hairmare
Copy link
Contributor Author

i put together a draft in #17904 and i hope it's not to ranty, any feedback is appreciated

@hairmare
Copy link
Contributor Author

i mentioned this effort in the ValKey discussion boards as well: https://github.com/orgs/valkey-io/discussions/340

@joebowbeer
Copy link
Contributor

joebowbeer commented Apr 25, 2024

Also see manifests/ha/base/redis-ha and manifests/ha/base/redis-ha/chart/requirements.yaml

For HA install of ArgoCD, the redis-ha configuration is provided by a 3rd party helm chart:

https://github.com/DandyDeveloper/charts/tree/master/charts/redis-ha

@todaywasawesome
Copy link
Contributor

Closing in favor of #17970 thank you @hairmare for opening this issue!

@todaywasawesome todaywasawesome closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants