Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add ValKey proposal #17892 #17904

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

docs: Add ValKey proposal #17892 #17904

wants to merge 1 commit into from

Conversation

hairmare
Copy link
Contributor

This proposal lays out a way forward toward replacing Redis as proposed in #17892

Closes #17892

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates? Yes
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@hairmare
docs: Add ValKey proposal
6b22133 
This proposal lays out a way forward toward replacing Redis.

Signed-off-by: Lucas <hairmare@purplehaze.ch>
@hairmare hairmare mentioned this pull request Apr 19, 2024
Closed
hairmare
hairmare commented Apr 19, 2024
View reviewed changes
docs/proposals/valkey.md
Comment on lines +5 to +12
sponsors:
- TBD # List all interested parties here.
reviewers:
- "@alexmt"
- TBD
approvers:
- "@alexmt"
- TBD
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't change these when i copied the template

thanks for letting me me know how to proceed

joebowbeer
joebowbeer reviewed Apr 25, 2024
View reviewed changes
docs/proposals/valkey.md

## Proposal

Given the nature of this change, fundamentally it should be as simple as replacing the container images in [manifests/base/redis](https://github.com/argoproj/argo-cd/tree/3a46e8c1c7dc20911cb5d87ade8ced26c766e273/manifests/base/redis).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see manifests/ha/base/redis-ha and manifests/ha/base/redis-ha/chart/requirements.yaml

For HA install of ArgoCD, the redis-ha configuration is provided by a 3rd party helm chart:

https://github.com/DandyDeveloper/charts/tree/master/charts/redis-ha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joebowbeer joebowbeer joebowbeer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Redis with ValKey
2 participants
@hairmare @joebowbeer