Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade redis-ha chart to 4.22.4 #11834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yu-croco
Copy link
Contributor

@yu-croco yu-croco commented Dec 27, 2022

ref: DandyDeveloper/charts#236


Signed-off-by: yu-croco yu.croco@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: yu-croco <yu.croco@gmail.com>
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Base: 47.32% // Head: 47.32% // No change to project coverage 👍

Coverage data is based on head (43d0d1f) compared to base (566d50f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11834   +/-   ##
=======================================
  Coverage   47.32%   47.32%           
=======================================
  Files         245      245           
  Lines       41545    41545           
=======================================
  Hits        19661    19661           
  Misses      19903    19903           
  Partials     1981     1981           
Impacted Files Coverage Δ
util/settings/settings.go 48.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yu-croco yu-croco marked this pull request as ready for review December 27, 2022 13:45
@hairmare
Copy link
Contributor

hairmare commented Apr 18, 2024

This PR is probably affected by the Redis License change, but the following issue would replace Redis with ValKey 7.2, just fyi

#17892

edit: scratch that, sorry for reaping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants