Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync with upstream commits #9

Merged
merged 9 commits into from Apr 21, 2023

Allow unsupported multi_ack capability

830e987
Select commit
Failed to load commit list.
Merged

sync with upstream commits #9

Allow unsupported multi_ack capability
830e987
Select commit
Failed to load commit list.
DCO / DCO required action Mar 27, 2023 in 0s

DCO

There are 7 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~9 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin cherrypicks

Summary

Commit sha: 3830da6, Author: Adrian Pronk, Committer: weafscast; The sign-off is missing.
Commit sha: 2294c6f, Author: Adrian Pronk, Committer: weafscast; The sign-off is missing.
Commit sha: 4654e0a, Author: Adrian Pronk, Committer: weafscast; The sign-off is missing.
Commit sha: db61985, Author: Adrian Pronk, Committer: weafscast; The sign-off is missing.
Commit sha: ab80dad, Author: Daniel Martí, Committer: weafscast; The sign-off is missing.
Commit sha: caff284, Author: Tobias Klauser, Committer: weafscast; The sign-off is missing.
Commit sha: 9eda8e8, Author: Tyler Christensen, Committer: weafscast; The sign-off is missing.

View more details on DCO