Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync with upstream commits #9

Merged
merged 9 commits into from Apr 21, 2023

Conversation

weafscast
Copy link

Fixes: argoproj/argo-workflows#10600

Besides normal plumbing cherrypicks, also cherrypicks : go-git#613

Azure DevOps requires capabilities multi_ack / multi_ack_detailed, which are not fully implemented and by default are included in transport.UnsupportedCapabilities.

The initial clone operations require a full download of the repository, and therefore those unsupported capabilities are not as crucial, so by removing them from that list allows for the first clone to work successfully.

Additional fetches will yield issues, therefore to support that repository users have to work from a clean clone until those capabilities are fully supported. Commits and pushes back into the repository have also been tested and work fine.

This PR adds an example for cloning Azure DevOps repositories.

cc/ @sarabala1979

Adrian Pronk and others added 9 commits March 22, 2023 20:12
The size of the similarity matrix is not limited and can be quite big
when lots of files are deleted and added in a commit.

Signed-off-by: Javi Fontan <jfontan@gmail.com>
(cherry picked from commit 1115cb6)
Use the syscall method instead of repeating the type conversions for
the syscall.Stat_t Atim/Atimespec/Ctim members.

(cherry picked from commit 4f91622)
…y value. (go-git#521)

Previously, calling `Set($CAPABILITY, ...)` on a `capability.List` where `$CAPABILITY`
was already present would correctly replace the existing value of that capability, but
would also result in that capability being listed twice in the internal `l.sort` slice.
This manifested publicly when the `List` was encoded as the same capability appearing
twice with the same value in the encoded output.

(cherry picked from commit 69aa78a)
Added in Go 1.12, this means we need one less dependency.

(cherry picked from commit bc1f419)
Azure DevOps requires capabilities multi_ack / multi_ack_detailed,
which are not fully implemented and by default are included in
transport.UnsupportedCapabilities.

The initial clone operations require a full download of the repository,
and therefore those unsupported capabilities are not as crucial, so
by removing them from that list allows for the first clone to work
successfully.

Additional fetches will yield issues, therefore to support that
repository users have to work from a clean clone until those
capabilities are fully supported. Commits and pushes back into the
repository have also been tested and work fine.

This change adds an example for cloning Azure DevOps repositories.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
(cherry picked from commit 9c7d2df)
@rohankmr414 rohankmr414 merged commit 5b35c41 into argoproj-labs:master Apr 21, 2023
1 check failed
@weafscast weafscast deleted the cherrypicks branch April 21, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure devops git repo unable to use git artifact
7 participants