Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect "thin pack" reference handling #110

Merged
merged 2 commits into from Mar 21, 2022
Merged

Fix incorrect "thin pack" reference handling #110

merged 2 commits into from Mar 21, 2022

Commits on Mar 21, 2022

  1. Add integration test for "thin pack" reference handling

    The `github.com/go-git/go-git/v5@v5.4.2` dependency used by this project to work with the Git repositories of the
    libraries is not able to correctly handle specific types of references in Git "thin packs", causing a spurious failure
    of the sync process for the affected libraries:
    
    Error fetching repository: reference delta not found
    
    This test is intended to check whether the project is able to correctly handle these libraries. I have simply used the
    two libraries from the report as test data. I am not confident they will continue to serve as effective test data
    indefinitely, but also don't know how to do the generation of test data that would serve as a reliable replacement for
    them, and noticed that those working on the `github.com/go-git/go-git` bug also did not find an easy way to do it.
    per1234 committed Mar 21, 2022
    Copy the full SHA
    6bd5694 View commit details
    Browse the repository at this point in the history
  2. Bump to version of github.com/go-git/go-git w/ correct "thin pack" …

    …handling
    
    The v5.4.2 version of the `github.com/go-git/go-git` module dependency used by this project to work with the Git
    repositories of the libraries was not able to correctly handle specific types of references in Git "thin packs", causing
    a spurious failure of the sync process for the affected libraries:
    
    Error fetching repository: reference delta not found
    
    The issue has been fixed already (go-git/go-git#392). Unfortunately, there has not been a release of
    `github.com/go-git/go-git` since that time, and the release cycle appears to be fairly long. For this reason, it is
    necessary to use a non-release version of the module in order to get access to the fix immediately. This project will
    resume using release versions of the dependency as soon as the next one is made.
    per1234 committed Mar 21, 2022
    Copy the full SHA
    dfccc33 View commit details
    Browse the repository at this point in the history