Fix incorrect "thin pack" reference handling #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `github.com/go-git/go-git/v5@v5.4.2` dependency used by this project to work with the Git repositories of the libraries is not able to correctly handle specific types of references in Git "thin packs", causing a spurious failure of the sync process for the affected libraries: Error fetching repository: reference delta not found This test is intended to check whether the project is able to correctly handle these libraries. I have simply used the two libraries from the report as test data. I am not confident they will continue to serve as effective test data indefinitely, but also don't know how to do the generation of test data that would serve as a reliable replacement for them, and noticed that those working on the `github.com/go-git/go-git` bug also did not find an easy way to do it.
per1234
added
topic: infrastructure
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
=======================================
Coverage 41.58% 41.58%
=======================================
Files 26 26
Lines 1450 1450
=======================================
Hits 603 603
Misses 790 790
Partials 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…handling The v5.4.2 version of the `github.com/go-git/go-git` module dependency used by this project to work with the Git repositories of the libraries was not able to correctly handle specific types of references in Git "thin packs", causing a spurious failure of the sync process for the affected libraries: Error fetching repository: reference delta not found The issue has been fixed already (go-git/go-git#392). Unfortunately, there has not been a release of `github.com/go-git/go-git` since that time, and the release cycle appears to be fairly long. For this reason, it is necessary to use a non-release version of the module in order to get access to the fix immediately. This project will resume using release versions of the dependency as soon as the next one is made.
umbynos
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v5.4.2 version of the
github.com/go-git/go-gitmodule dependency used by this project to work with the Git repositories of the libraries was not able to correctly handle specific types of references in Git "thin packs" (go-git/go-git#190), which caused a spurious failure of thesyncprocess for the affected libraries (#109):(currently visible at http://downloads.arduino.cc/libraries/logs/github.com/RAKWireless/RAK14012-LED-Matrix/)
(currently visible at http://downloads.arduino.cc/libraries/logs/github.com/RAKWireless/RAK12021-TCS37725/)
The issue has already been fixed (go-git/go-git#392). Unfortunately, there has not been a release of
github.com/go-git/go-gitsince that time, and the release cycle appears to be fairly long. For this reason, it is necessary to temporarily use a non-release version of the module in order to get access to the fix immediately. This project will resume using release versions as soon as the next one is made.I added an integration test which is intended to check whether the project is able to correctly handle these libraries. I have simply used the two libraries from the report as test data. I am not confident they will continue to serve as effective test data indefinitely, but also don't know how to do the generation of test data that would serve as a reliable replacement for them, and noticed that those working on the
github.com/go-git/go-gitbug also did not find an easy way to do it.Fixes #109