Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add soh335/shukujitsu #9556

Merged
merged 3 commits into from Feb 1, 2023
Merged

feat: add soh335/shukujitsu #9556

merged 3 commits into from Feb 1, 2023

Conversation

ponkio-o
Copy link
Sponsor Contributor

@ponkio-o ponkio-o commented Feb 1, 2023 •
edited

#9556 soh335/shukujitsu: shukujitsu determines japanese holiday. Holidays are collected from https://www8.cao.go.jp/chosei/shukujitsu/shukujitsu.csv

$ aqua g -i soh335/shukujitsu

How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well. Please confirm if this package works well yourself as much as possible.

Command and output

$ shukujitsu --help
Usage of /Users/user/.local/share/aquaproj-aqua/pkgs/github_release/github.com/soh335/shukujitsu/v0.0.5/shukujitsu_0.0.5_darwin_amd64.tar.gz/shukujitsu:
  -date string
        date (format 2006-01-02)
  -quiet
        quiet
  -version
        show version
$ shukujitsu --date 2023-02-23
2023-02-23 天皇誕生日

Reference

@ponkio-o
feat: add soh335/shukujitsu
a003cb4 
[soh335/shukujitsu](https://github.com/soh335/shukujitsu):

```console
$ aqua g -i soh335/shukujitsu
```

## How to confirm if this package works well

Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.

Command and output

```console
$
```

If files such as configuration file are needed, please share them.

```
```

Reference

-
@ponkio-o
fix: remove white line
00937b3
@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Feb 1, 2023

aqua-registry scaffold command added unnecessary blank lines 🤔
00937b3

$ aqua-registry -version
aqua-registry version 0.1.6 (291d904ed1c7b8954068c1dada00dfc7353dd7ae)

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Feb 1, 2023
@suzuki-shunsuke suzuki-shunsuke added this to the v3.127.0 milestone Feb 1, 2023
@suzuki-shunsuke
Copy link
Member

aqua-registry scaffold command added unnecessary blank lines 🤔 00937b3

$ aqua-registry -version
aqua-registry version 0.1.6 (291d904ed1c7b8954068c1dada00dfc7353dd7ae)

Oh, really? I'll take a look later. Thank you for your report.

@suzuki-shunsuke
Copy link
Member

Ah, maybe this one.

@suzuki-shunsuke
Copy link
Member

Which version of aqua are you using?
Please update aqua to v1.30.4 or later.

@suzuki-shunsuke
Copy link
Member

Oh, sorry. I misunderstood.
aqua generate-registry is different from aqua generate.
I'll take a look.

@suzuki-shunsuke
Copy link
Member

Added description. 07fc5c4

@suzuki-shunsuke suzuki-shunsuke merged commit 6c0dc8a into aquaproj:main Feb 1, 2023
@ponkio-o
Copy link
Sponsor Contributor Author

ponkio-o commented Feb 1, 2023

Added description. 07fc5c4

Thank you!

@suzuki-shunsuke
Copy link
Member

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.127.0

@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Feb 2, 2023
Closed
@suzuki-shunsuke
Copy link
Member

aqua-registry scaffold command added unnecessary blank lines 🤔 00937b3

$ aqua-registry -version
aqua-registry version 0.1.6 (291d904ed1c7b8954068c1dada00dfc7353dd7ae)

Created an issue.

@ponkio-o ponkio-o deleted the feat/soh335/shukujitsu branch February 2, 2023 01:43
@suzuki-shunsuke
Copy link
Member

The above bug has been fixed. aquaproj/registry-tool#276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.127.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ponkio-o @suzuki-shunsuke