scaffold command adds an unneeded newline at the end of output

[suzuki-shunsuke]

• feat: add soh335/shukujitsu aqua-registry#9556 (comment)

How to reproduce

$ aqua-registry -v
aqua-registry version 0.1.6 (291d904ed1c7b8954068c1dada00dfc7353dd7ae)

$ aqua -v
aqua version 1.32.2 (4f892abd43f2781d1252f794072d59a64a369857)

$ aqua-registry scaffold soh335/shukujitsu

packages:
  - type: github_release
    repo_owner: soh335
    repo_name: shukujitsu
    asset: shukujitsu_{{trimV .Version}}_{{.OS}}_{{.Arch}}.tar.gz
    supported_envs:
      - linux
      - darwin
    checksum:
      type: github_release
      asset: checksums.txt
      file_format: regexp
      algorithm: sha256
      pattern:
        checksum: "^(\\b[A-Fa-f0-9]{64}\\b)"
        file: "^\\b[A-Fa-f0-9]{64}\\b\\s+(\\S+)$"
# unnecessary newline

[suzuki-shunsuke]

aqua gr doesn't add a newline.

aqua gr soh335/shukujitsu > test.yaml

packages:
  - type: github_release
    repo_owner: soh335
    repo_name: shukujitsu
    asset: shukujitsu_{{trimV .Version}}_{{.OS}}_{{.Arch}}.tar.gz
    supported_envs:
      - linux
      - darwin
    checksum:
      type: github_release
      asset: checksums.txt
      file_format: regexp
      algorithm: sha256
      pattern:
        checksum: "^(\\b[A-Fa-f0-9]{64}\\b)"
        file: "^\\b[A-Fa-f0-9]{64}\\b\\s+(\\S+)$"

[suzuki-shunsuke]

I found the cause.

registry-tool/pkg/scaffold/api.go

Lines 72 to 74 in e7f7b55

	if err := patchchecksum.PatchChecksum(ctx, logE, rgFilePath); err != nil {
	return fmt.Errorf("patch the checksum config: %w", err)
	}

registry-tool/pkg/patchchecksum/patch.go

Line 55 in e7f7b55

if err := os.WriteFile(configFilePath, []byte(file.String()+"\n"), 0o644); err != nil { //nolint:gosec,gomnd

• fix(generate): remove a newline aqua#1541

[suzuki-shunsuke]

I think PatchChecksum isn't needed anymore, because this is for old aqua.
When we released checksum verification, we expected users use old aqua which didn't support checksum verification, so we patched checksum settings in registry-tool.
registry-tool is managed by aqua, so we can force users to update registry-tool automatically.

The drawback of PatchChecksum is that we have to maintain this function.

[suzuki-shunsuke]

Updated.

• chore(deps): update dependency aquaproj/registry-tool to v0.1.7 aqua-registry#9594