[openshift_resource] raise KeyError when adding an item #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Piojo how would you like to proceed? |
|
I'll have to insist on #1868, I gave the full details in our slack thread: https://coreos.slack.com/archives/GGC2A0MS8/p1632895377320900 . Also, for the new #1892 - it calls |
|
agreed on the same slack thread to merge this one and split the other changes to separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://issues.redhat.com/browse/APPSRE-3668
attempts to replace #1868 (which reverts a revert of #1851).
re-adds functionality which was lost in #1232.
when a KeyError is raised, it means that the resource kind that is referenced from a namespace file under
openshiftResourcesis not mentioned inmanagedResourceTypes.the only integrations which takes the
managedResourceTypesinto account is openshift-resources.release candidate tested in https://gitlab.cee.redhat.com/service/app-interface/-/merge_requests/26164 (
make rc)