openshift_resource raise KeyError when adding an item (#1880)

app-sre · Oct 6, 2021 · 747242e · 747242e
1 parent c00246c
commit 747242e
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/reconcile/utils/openshift_resource.py b/reconcile/utils/openshift_resource.py
@@ -448,24 +448,18 @@ def initialize_resource_type(self, cluster, namespace, resource_type):
 
     def add_desired(self, cluster, namespace, resource_type, name, value):
         with self._lock:
-            try:
-                desired = \
-                    (self._clusters[cluster][namespace][resource_type]
-                        ['desired'])
-            except KeyError:
-                return None
+            desired = \
+                (self._clusters[cluster][namespace][resource_type]
+                    ['desired'])
             if name in desired:
                 raise ResourceKeyExistsError(name)
             desired[name] = value
 
     def add_current(self, cluster, namespace, resource_type, name, value):
         with self._lock:
-            try:
-                current = \
-                    (self._clusters[cluster][namespace][resource_type]
-                        ['current'])
-            except KeyError:
-                return None
+            current = \
+                (self._clusters[cluster][namespace][resource_type]
+                    ['current'])
             current[name] = value
 
     def __iter__(self):