Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bundle of dependency issues #6393

Merged
merged 1 commit into from May 5, 2022
Merged

Fix a bundle of dependency issues #6393

merged 1 commit into from May 5, 2022

Commits on May 5, 2022

  1. Fix a bundle of dependency issues 

    Some packages were depending on other packages that were only declared
as transitive dependencies. Clean this up by adding appropriate
dependencies (or in one case, just re-declaring ValueOrPromise and
dropping the apollo-server-types dependency).

The peer dep one is a bit funny.  But "Y has a peer dep on Z" means
"when you install Y you need to install Z", and so if X depends on Y,
then when you install X you need to install Z... so sure, that means X
needs to have a peer dep on Z too, I guess.

Fixes #6389.
Fixes #6390.
Fixes #6391.
Fixes #6392.
    @glasser
    glasser committed May 5, 2022
    Copy the full SHA
    e3c078e View commit details
    Browse the repository at this point in the history