Fix a bundle of dependency issues #6393
Conversation
✅ Deploy Preview for apollo-server-docs canceled.
|
Some packages were depending on other packages that were only declared as transitive dependencies. Clean this up by adding appropriate dependencies (or in one case, just re-declaring ValueOrPromise and dropping the apollo-server-types dependency). The peer dep one is a bit funny. But "Y has a peer dep on Z" means "when you install Y you need to install Z", and so if X depends on Y, then when you install X you need to install Z... so sure, that means X needs to have a peer dep on Z too, I guess. Fixes #6389. Fixes #6390. Fixes #6391. Fixes #6392.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e3c078e:
|
| @@ -22,6 +22,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/apollographql/apollo-server#readme", | |||
| "dependencies": { | |||
| "@types/express": "4.17.13", | |||
There was a problem hiding this comment.
Does it need to be pinned? ):
There was a problem hiding this comment.
It's pinned like this in apollo-server-express so I figured doing the same thing was reasonable.
We've had a lot of challenges with the Express DefinitelyTyped packages before. They factored out a huge part of the types from @types/express into @types/express-serve-static-core but the dependency of the former on the latter doesn't declare a specific version, so it's easy to accidentally install a pair of versions that don't work together. So unfortunately trying to pin more precisely does seem helpful. If they get behind we're happy to update everything...
Some packages were depending on other packages that were only declared
as transitive dependencies. Clean this up by adding appropriate
dependencies (or in one case, just re-declaring ValueOrPromise and
dropping the apollo-server-types dependency).
The peer dep one is a bit funny. But "Y has a peer dep on Z" means
"when you install Y you need to install Z", and so if X depends on Y,
then when you install X you need to install Z... so sure, that means X
needs to have a peer dep on Z too, I guess.
Fixes #6389.
Fixes #6390.
Fixes #6391.
Fixes #6392.