Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline and improve the stoppable package #5498

Merged
merged 12 commits into from
Jul 23, 2021
Merged

Inline and improve the stoppable package #5498

merged 12 commits into from
Jul 23, 2021

Commits on Jul 23, 2021

  1. Add the JavaScript stoppable implementation 

    This is from https://github.com/hunterloftis/stoppable and is MIT
licensed.
    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    79ff79c View commit details
    Browse the repository at this point in the history

  2. Basic TypeScript conversion

    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    463b7a5 View commit details
    Browse the repository at this point in the history

  3. Refactor to return an async function 

    Instead of adding a callback-y function to the server.
    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    84b80ad View commit details
    Browse the repository at this point in the history

  4. Rename parameter to match what we call it in the API

    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    64fca16 View commit details
    Browse the repository at this point in the history

  5. Don't call unref on the timeout 

    See hunterloftis/stoppable#33

Fixes #4933
    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    08cada0 View commit details
    Browse the repository at this point in the history

  6. Replace use of upstream with the fork

    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    26ac42c View commit details
    Browse the repository at this point in the history

  7. Add the JavaScript stoppable test suite

    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    aadbeb6 View commit details
    Browse the repository at this point in the history

  8. First pass at rewriting tests in TS

    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    f90ad02 View commit details
    Browse the repository at this point in the history

  9. Refactor to an object so that tests can look at reqsPerSocket

    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    9f4cfb9 View commit details
    Browse the repository at this point in the history

  10. Clean up http Agents after tests 

    Fixes "Jest did not exit one second after the test run has completed."
issue.
    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    cb3fc84 View commit details
    Browse the repository at this point in the history

  11. Restore test that runs a separate process

    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    2f45dd3 View commit details
    Browse the repository at this point in the history

  12. Refactor to repeat less

    @glasser
    glasser committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    26638b0 View commit details
    Browse the repository at this point in the history