Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline and improve the stoppable package #5498

Merged
merged 12 commits into from Jul 23, 2021
Merged

Inline and improve the stoppable package #5498

merged 12 commits into from Jul 23, 2021

Conversation

glasser
Copy link
Member

@glasser glasser commented Jul 16, 2021 •
edited

This is part of #5074.

This PR takes the small MIT-licensed package stoppable and its test suite and moves them into the apollo-server package. (Though once #5074 is done, it should end up in apollo-server-core instead.) This package is helpful but it hasn't been updated in years and PRs like hunterloftis/stoppable#33 have not been merged.

Advantages of this version over the upstream:

@glasser glasser changed the title Glasser/inline stoppable wip: inline and improve the stoppable package Jul 16, 2021
@glasser glasser mentioned this pull request Jul 16, 2021
Closed
@glasser glasser added the size/small Estimated to take LESS THAN A DAY label Jul 16, 2021
@glasser glasser self-assigned this Jul 16, 2021
@glasser glasser added this to the MM-2021-07 milestone Jul 16, 2021
@glasser glasser added size/medium Estimated to take LESS THAN A WEEK and removed size/small Estimated to take LESS THAN A DAY labels Jul 19, 2021
@glasser glasser changed the title wip: inline and improve the stoppable package Inline and improve the stoppable package Jul 19, 2021
@glasser glasser marked this pull request as ready for review July 19, 2021 21:05
@glasser glasser changed the base branch from main to release-3.1.0 July 23, 2021 05:48
@glasser
Add the JavaScript stoppable implementation
79ff79c 
This is from https://github.com/hunterloftis/stoppable and is MIT
licensed.
@glasser
Basic TypeScript conversion
463b7a5
@glasser
Refactor to return an async function
84b80ad 
Instead of adding a callback-y function to the server.
@glasser
Rename parameter to match what we call it in the API
64fca16
@glasser
Don't call unref on the timeout
08cada0 
See hunterloftis/stoppable#33

Fixes #4933
@glasser
Replace use of upstream with the fork
26ac42c
@glasser
Add the JavaScript stoppable test suite
aadbeb6
@glasser
First pass at rewriting tests in TS
f90ad02
@glasser
Refactor to an object so that tests can look at reqsPerSocket
9f4cfb9
@glasser
Clean up http Agents after tests
cb3fc84 
Fixes "Jest did not exit one second after the test run has completed."
issue.
@glasser
Restore test that runs a separate process
2f45dd3
@glasser
Refactor to repeat less
26638b0
@glasser glasser merged commit 42ddaa6 into release-3.1.0 Jul 23, 2021
@glasser glasser deleted the glasser/inline-stoppable branch July 23, 2021 05:52
@hwillson hwillson removed this from the MM-2021-07 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trevor-scheer trevor-scheer Awaiting requested review from trevor-scheer

Assignees

@glasser glasser

Labels
size/medium Estimated to take LESS THAN A WEEK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apollo-server's stop() hangs when running in jest jsdom browser-emulation mode due to lack of timer.unref
2 participants
@glasser @hwillson