Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getIntrospectionQuery rather than introspectionQuery constant. #5748

Merged
merged 1 commit into from
Jan 3, 2020

Commits on Jan 3, 2020

  1. Use getIntrospectionQuery rather than introspectionQuery constant.

    The next major version of `graphql-js` deprecates the `introspectionQuery`
    constant (thanks to graphql/graphql-js#2124) that
    was previously leveraged in Apollo Client tests for obtaining the
    introspection query (to be clear, this is the query used to introspect a
    server, not the result of the introspection itself) in one particular test.
    
    This deprecation isn't entirely surprising since the `getIntrospectionQuery`
    utility method has existed since `graphql@0.12` and is the recommended way
    to obtain this query in more recent versions of `graphql`, so this changes
    that test to use that new method.
    
    I discovered this while investigating our compatibility with the most
    recently published `graphql@15.0.0-alpha.2` on `apollo-server`,
    `apollo-tooling` and `apollo-client`.  Other than this, I didn't encounter
    any test failures when updating the root `graphql` dev-dependency to
    `graphql@15.0.0-alpha.2`!
    
    Deprecated by: graphql/graphql-js#2124
    In Response to: graphql/graphql-js#2303
    Relates to: apollographql/apollo-server#3649
    Relates to: apollographql/apollo-tooling#1743
    abernix committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    4dc0217 View commit details
    Browse the repository at this point in the history