Use getIntrospectionQuery rather than introspectionQuery constant.
#5748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next major version of `graphql-js` deprecates the `introspectionQuery` constant (thanks to graphql/graphql-js#2124) that was previously leveraged in Apollo Client tests for obtaining the introspection query (to be clear, this is the query used to introspect a server, not the result of the introspection itself) in one particular test. This deprecation isn't entirely surprising since the `getIntrospectionQuery` utility method has existed since `graphql@0.12` and is the recommended way to obtain this query in more recent versions of `graphql`, so this changes that test to use that new method. I discovered this while investigating our compatibility with the most recently published `graphql@15.0.0-alpha.2` on `apollo-server`, `apollo-tooling` and `apollo-client`. Other than this, I didn't encounter any test failures when updating the root `graphql` dev-dependency to `graphql@15.0.0-alpha.2`! Deprecated by: graphql/graphql-js#2124 In Response to: graphql/graphql-js#2303 Relates to: apollographql/apollo-server#3649 Relates to: apollographql/apollo-tooling#1743
benjamn
approved these changes
Jan 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next major version of
graphql-jsdeprecates theintrospectionQueryconstant (thanks to graphql/graphql-js#2124) that was previously leveraged in Apollo Client tests for obtaining the introspection query (to be clear, this is the query used to introspect a server, not the result of the introspection itself) in one particular test.This deprecation isn't entirely surprising since the
getIntrospectionQueryutility method has existed sincegraphql@0.12and is the recommended way to obtain this query in more recent versions ofgraphql, so this changes that test to use that new method.I discovered this while investigating our compatibility with the most recently published
graphql@15.0.0-alpha.2onapollo-server,apollo-toolingandapollo-client. Other than this, I didn't encounter any test failures when updating the rootgraphqldev-dependency tographql@15.0.0-alpha.2!Deprecated by: graphql/graphql-js#2124
In Response to: graphql/graphql-js#2303
Relates to: apollographql/apollo-server#3649
Relates to: apollographql/apollo-tooling#1743