Use rust-bitcoin-maintainer-tools and re-write CI #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks like the We also probably want to pin nightly rustc in the same PR. |
tcharding
force-pushed
the
05-17-ci-maintainer-tools
branch
from
bf1f843
to
bb77e42
Compare
tcharding
force-pushed
the
05-17-ci-maintainer-tools
branch
2 times, most recently
from
78f6004
to
0513663
Compare
tcharding
force-pushed
the
05-17-ci-maintainer-tools
branch
from
0513663
to
6ffa4a3
Compare
|
Note please the recent and minimal lock files are the same. I spent 10 minutes trying to fix them otherwise, but my fingers started to bleed. Also, I'll fix the lint job after #117 goes in. |
tcharding
force-pushed
the
05-17-ci-maintainer-tools
branch
from
6ffa4a3
to
68c497e
Compare
In preparation for using a pinned nightly in CI add a `nightly-version` file and also a `justfile` that uses it.
As we have been doing in other crates, use the new maintainer tools test script we created from `rust-bitcoin/rust-bitcoin-maintainer-tools/ci`. - This should not change test coverage in any meaningful way. - The integration tests are not currently run in CI, this patch preserves that behaviour. - Introduces recent/minimal lock files.
tcharding
force-pushed
the
05-17-ci-maintainer-tools
branch
from
68c497e
to
61dd7b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have been doing in other crates, use the new maintainer tools test script we created from
rust-bitcoin/rust-bitcoin-maintainer-tools/ci.