Allow assigning_clones #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clone_into` is only available in Rust 1.63 and since our MSRV is Rust 1.48 just shoosh clippy
Merged
Is there a bug about |
|
There is, which was fixed 2 months ago: rust-lang/rust-clippy#12502 The lint has also been moved to "pedantic" and allow-by-default. https://rust-lang.github.io/rust-clippy/master/index.html#/assigning_clones I'm confused as to why it's affecting us now. |
|
Oh, I see, this made it into stable :(. |
|
@tcharding let's do a global whitelist of this lint since it's broken, and that is not specific to any codepath. |
|
Now in #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clone_intois only available in Rust 1.63 and since our MSRV is Rust 1.48 just shoosh clippy