Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid php8 only syntax when possible #4636

Closed
wants to merge 1 commit into from
Closed

Avoid php8 only syntax when possible #4636

wants to merge 1 commit into from

Commits on Jan 17, 2022

  1. Avoid php8 only syntax when possible 

    This resulted in phpstan to fail if the active PHP version is <8.0:
Internal error: syntax error, unexpected 'static' (T_STATIC)

In case a project depending on api-platform/core would use ClientTrait directly,
or indirectly, phpstan would try to parse it and fail with the above syntax error.

Move the type declarations into a comment instead.

Fixes api-platform#4614
    @lazka
    lazka committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    a5e66e5 View commit details
    Browse the repository at this point in the history