Avoid php8 only syntax when possible #4636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in phpstan to fail if the active PHP version is <8.0: Internal error: syntax error, unexpected 'static' (T_STATIC) In case a project depending on api-platform/core would use ClientTrait directly, or indirectly, phpstan would try to parse it and fail with the above syntax error. Move the type declarations into a comment instead. Fixes api-platform#4614
|
But then it's phpstan fault that it cannot understand the code :) I'd suggest for you then to make phpstan happy, override the createClient method and adapt not to use that trait |
|
ok, I'll file a bug with phpstan then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resulted in phpstan to fail if the active PHP version is <8.0:
Internal error: syntax error, unexpected 'static' (T_STATIC)
In case a project depending on api-platform/core would use ClientTrait directly,
or indirectly, phpstan would try to parse it and fail with the above syntax error.
Move the type declarations into a comment instead.