Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35210][BUILD][2.4] Upgrade Jetty to 9.4.40 to fix ERR_CONNECTION_RESET issue #32322

Closed
wants to merge 2 commits into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Apr 24, 2021

What changes were proposed in this pull request?

This PR backports SPARK-35210 (#32318).
This PR proposes to upgrade Jetty to 9.4.40.

Why are the changes needed?

SPARK-34988 (#32091) upgraded Jetty to 9.4.39 for CVE-2021-28165.
But after the upgrade, Jetty 9.4.40 was released to fix the ERR_CONNECTION_RESET issue (jetty/jetty.project#6152).
This issue seems to affect Jetty 9.4.39 when POST method is used with SSL.
For Spark, job submission using REST and ThriftServer with HTTPS protocol can be affected.

Does this PR introduce any user-facing change?

No. No released version uses Jetty 9.3.39.

How was this patch tested?

CI.

@sarutak
Copy link
Member Author

sarutak commented Apr 24, 2021

cc: @viirya

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Test build #137884 has finished for PR 32322 at commit dfbb3ef.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42410/

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42410/

@viirya
Copy link
Member

viirya commented Apr 24, 2021

retest this please

@SparkQA

This comment has been minimized.

@viirya
Copy link
Member

viirya commented Apr 24, 2021

retest this please

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42416/

@SparkQA

This comment has been minimized.

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42416/

@viirya
Copy link
Member

viirya commented Apr 24, 2021

Spark's published dependencies DO NOT MATCH the manifest file (dev/spark-deps).
To update the manifest file, run './dev/test-dependencies.sh --replace-manifest'.

Oh, seems we need to update the manifest files. @sarutak Can you update it? Thanks.

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42418/

@SparkQA
Copy link

SparkQA commented Apr 24, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42418/

@dongjoon-hyun
Copy link
Member

Ya, +1 for @viirya 's comment.

@sarutak
Copy link
Member Author

sarutak commented Apr 25, 2021

Ah, I forgot to do it. Thanks.

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42426/

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42426/

@SparkQA
Copy link

SparkQA commented Apr 25, 2021

Test build #137901 has finished for PR 32322 at commit 4495701.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Apr 25, 2021

Thanks. Merging to 2.4.

viirya pushed a commit that referenced this pull request Apr 25, 2021
…ON_RESET issue

### What changes were proposed in this pull request?

This PR backports SPARK-35210 (#32318).
This PR proposes to upgrade Jetty to 9.4.40.

### Why are the changes needed?

SPARK-34988 (#32091) upgraded Jetty to 9.4.39 for CVE-2021-28165.
But after the upgrade, Jetty 9.4.40 was released to fix the ERR_CONNECTION_RESET issue (jetty/jetty.project#6152).
This issue seems to affect Jetty 9.4.39 when POST method is used with SSL.
For Spark, job submission using REST and ThriftServer with HTTPS protocol can be affected.

### Does this PR introduce _any_ user-facing change?

No. No released version uses Jetty 9.3.39.

### How was this patch tested?

CI.

Closes #32322 from sarutak/backport-SPARK-35210.

Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com>
Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
@viirya viirya closed this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants