[fix][broker] avoid offload system topic #22497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid setting broker internal system topics using off-loader because some of them are the preconditions of other topics. The slow replying log speed will cause a delay in all the topic loading.(timeout)
mattisonchao
added
category/reliability
Technoboy-
approved these changes
Apr 14, 2024
Coselding
approved these changes
Apr 15, 2024
lhotari
reviewed
Apr 15, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
lhotari
reviewed
Apr 16, 2024
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerTestBase.java
Outdated
Show resolved
Hide resolved
15 tasks
|
@mattisonchao Why do we closed this PR? |
|
discussed with @mattisonchao , reopen the PR |
RobertIndie
approved these changes
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22497 +/- ##
=============================================
- Coverage 73.57% 41.94% -31.63%
+ Complexity 32624 15011 -17613
=============================================
Files 1877 1749 -128
Lines 139502 139850 +348
Branches 15299 16220 +921
=============================================
- Hits 102638 58660 -43978
- Misses 28908 73885 +44977
+ Partials 7956 7305 -651
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
pushed a commit
that referenced
this pull request
May 8, 2024
Co-authored-by: 道君 <daojun@apache.org>
lhotari
pushed a commit
that referenced
this pull request
May 14, 2024
Co-authored-by: 道君 <daojun@apache.org> (cherry picked from commit 3114199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid setting broker internal system topics using off-loader because some of them are the preconditions of other topics. The slow replying log speed will cause a delay in all the topic loading.(timeout)
Modifications
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete