Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] prevent offload non-persistent or system topics #22612

Closed
wants to merge 1 commit into from

Conversation

chunxiaozheng
Copy link

When ledger is closed, do not offload when this ledger is non-persistent or system topics.

Motivation

When ledger is closed, do not offload when this ledger is non-persistent or system topics.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 29, 2024
@dao-jun
Copy link
Member

dao-jun commented Apr 29, 2024

NonPersistentTopic has no ledgers to persist messages, so we don't need to care about it.
About SystemTopic, I remember there is a PR to fix it

@dao-jun
Copy link
Member

dao-jun commented Apr 29, 2024

Got it, #22497

@chunxiaozheng
Copy link
Author

Got it, #22497

Thanks! But I see the #22497 did not merge. In our scenario, due to system topic triggered offload, many exceptions were printed in the log, so I submitted the above modifications

@dao-jun
Copy link
Member

dao-jun commented Apr 29, 2024

Got it, #22497

Thanks! But I see the #22497 did not merge. In our scenario, due to system topic triggered offload, many exceptions were printed in the log, so I submitted the above modifications

let me ask him, if there is no other problems, I'll reopen and merge it

@chunxiaozheng
Copy link
Author

Got it, #22497

Thanks! But I see the #22497 did not merge. In our scenario, due to system topic triggered offload, many exceptions were printed in the log, so I submitted the above modifications

let me ask him, if there is no other problems, I'll reopen and merge it

Thanks!

@dao-jun
Copy link
Member

dao-jun commented May 8, 2024

@chunxiaozheng #22497 merged, let's close this PR

@chunxiaozheng
Copy link
Author

@chunxiaozheng #22497 merged, let's close this PR

okay,thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants