Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[branch-2.10] Fix flaky test #21135

Merged
merged 3 commits into from
Sep 6, 2023
Merged

[branch-2.10] Fix flaky test #21135

merged 3 commits into from
Sep 6, 2023

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Sep 5, 2023 •
edited

Motivation

Fix flaky tests of branch-2.10

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Sep 5, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 5, 2023
@mattisonchao mattisonchao mentioned this pull request Sep 5, 2023
Merged
4 tasks
poorbarcode
poorbarcode approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@poorbarcode poorbarcode left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test LoadSimulationController also set the arg watch to null, could you fix it too?

horizonzy
horizonzy approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui merged commit 1300eb5 into apache:branch-2.10 Sep 6, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@horizonzy horizonzy horizonzy approved these changes

@poorbarcode poorbarcode poorbarcode approved these changes

@coderzc coderzc Awaiting requested review from coderzc

Assignees

@mattisonchao mattisonchao

Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattisonchao @codelipenghui @horizonzy @poorbarcode